Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1390: Consultation #285

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Adds new procedure for consultation
  • Add consultation terms

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1390

The consultation procedure is part of the 8.1 updates for improving NAGPRA workflows. It adds the ability to document the consultation process itself.

How should this be tested? Do these changes have associated tests?

  • Rebuild collectionspace with the related services PR and tenants required for running integration tests
  • Start collectionspace
  • Run the integration tests

Dependencies for merging? Releasing to production?
I wasn't sure what to use for the mini=summary field, so hopefully the involvedParty is sufficient.

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter ran the integration tests locally

@mikejritter mikejritter force-pushed the nagpra-consultation branch from 7311e8e to 7549ba9 Compare June 26, 2024 21:45
@mikejritter mikejritter changed the title Nagpra consultation DRYD-1390: Consultation Jun 26, 2024
@mikejritter mikejritter requested a review from ray-lee June 27, 2024 17:29
Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit e826697 into collectionspace:master Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants