DRYD-1358: Held-in-Trust Updates #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1358
Instead of creating a new CulturalCare procedure, we're opting to pull the cultural care fields directly into Held-in-Trust. Along with this we're adding the existing term lists for cultural care into the base-vocabularies so that they can be used in core.
This is also updating the default terms for heldintrusttype, which we were previously waiting on.
How should this be tested? Do these changes have associated tests?
Dependencies for merging? Releasing to production?
I didn't update the culturalcare-vocabularies yet or remove it from the lhmc or anthro config. Since these PRs have been focused on core, I've only made changes with that in mind. For this I could go and update lhmc and anthro though.
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter tested against a local instance