Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in write_riemann #3351

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Fix memory leak in write_riemann #3351

merged 1 commit into from
Dec 5, 2019

Conversation

faxm0dem
Copy link
Contributor

@faxm0dem faxm0dem commented Dec 4, 2019

Changelog: Fix memory leak in write_riemann
Change-Id: If95da8d90c078c19ac0062e3bbb006185dcc441d

@faxm0dem faxm0dem force-pushed the f/write_riemann-memleak branch 2 times, most recently from 955ae81 to 18d7814 Compare December 4, 2019 15:02
@faxm0dem faxm0dem changed the title WIP: Fix memory leak in write_riemann Fix memory leak in write_riemann Dec 4, 2019
@faxm0dem faxm0dem marked this pull request as ready for review December 4, 2019 15:03
rubenk
rubenk reviewed Dec 4, 2019
View reviewed changes
@faxm0dem faxm0dem force-pushed the f/write_riemann-memleak branch from 5ec710a to 18d7814 Compare December 4, 2019 15:41
@faxm0dem
Copy link
Contributor Author

faxm0dem commented Dec 4, 2019

I was trying to fix this (lesser) one:

==30694== 331 (192 direct, 139 indirect) bytes in 1 blocks are definitely lost in loss record 40 of 53
==30694==    at 0x4C2BFB9: calloc (vg_replace_malloc.c:762)
==30694==    by 0x6539FB6: wrr_config_node (write_riemann.c:643)
==30694==    by 0x6539FB6: wrr_config (write_riemann.c:853)
==30694==    by 0x1101BE: dispatch_block_plugin (configfile.c:408)
==30694==    by 0x1119E7: dispatch_block (configfile.c:442)
==30694==    by 0x1119E7: cf_read (configfile.c:1034)
==30694==    by 0x10F335: configure_collectd (collectd.c:360)
==30694==    by 0x10F335: init_config (collectd.c:410)
==30694==    by 0x10E6A0: main (cmd.c:167)

@faxm0dem
Copy link
Contributor Author

faxm0dem commented Dec 4, 2019

But I'll do that in a separate PR. this one is major an needs to be merged asap ;-)

@rubenk
Copy link
Contributor

rubenk commented Dec 5, 2019

I take it this doesn't just happen in master? Can you open this PR against the oldest stable branch where this applies?

@faxm0dem faxm0dem changed the base branch from master to collectd-5.9 December 5, 2019 09:51
@rpv-tomsk
Copy link
Contributor

As I see, if such PR would be correct, untrusted maintainers still has no way to merge PR untill "code owner" from Intel approve this.

Be happy, dear maintainers, you treated as unskilled workers here.

@rubenk
Copy link
Contributor

rubenk commented Dec 5, 2019

@faxm0dem can you rebase on that branch?

@faxm0dem faxm0dem force-pushed the f/write_riemann-memleak branch from 18d7814 to afc2260 Compare December 5, 2019 11:50
Fix memory leak in write_riemann
0065384 
Trivia: this cost a user €1844,28160184475 in electricity (~3TB of RAM
freed)

Changelog: Fix memory leak in write_riemann
Change-Id: If95da8d90c078c19ac0062e3bbb006185dcc441d
@faxm0dem faxm0dem force-pushed the f/write_riemann-memleak branch from afc2260 to 0065384 Compare December 5, 2019 11:51
smortex
smortex approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@smortex smortex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, looks like I introduced this bug in #3158. Thanks for fixing it!

smortex
smortex approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@smortex smortex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, looks like I introduced this bug in #3158. Thanks for fixing it!

@rubenk rubenk merged commit f3502f2 into collectd:collectd-5.9 Dec 5, 2019
@faxm0dem
Copy link
Contributor Author

faxm0dem commented Dec 5, 2019

@smortex read the commit message to know how much money you owe us 🤣

@smortex
Copy link
Contributor

smortex commented Dec 5, 2019

Outch! I would be interested in more details!

@faxm0dem faxm0dem mentioned this pull request Mar 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenk rubenk rubenk approved these changes

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@faxm0dem @rubenk @rpv-tomsk @smortex