Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocess method #468

Closed
wants to merge 2 commits into from
Closed

Conversation

bitlab-code
Copy link

@bitlab-code bitlab-code commented May 25, 2021

WIP: some tests fail.
There is and issue with optional, nullable and default.
Need help.

@carlpaten
Copy link
Collaborator

Can you describe the intended difference with .transform?

@scotttrinh
Copy link
Collaborator

@LilRed

Can you describe the intended difference with .transform?

I believe the idea here is that this runs before hitting the input type parser, so you can change the input data. Discussed in here and here

@carlpaten carlpaten marked this pull request as ready for review July 12, 2021 14:55
@carlpaten carlpaten marked this pull request as draft July 12, 2021 14:58
@carlpaten
Copy link
Collaborator

I removed the "draft" status on this PR expecting the CI to run but that didn't happen. I'll run the tests locally as soon as I have some time.

@colinhacks
Copy link
Owner

A slightly different implementation of this feature was added in [email protected]. Thanks @bitlab-code !

@colinhacks colinhacks closed this Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants