Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Add support for missing 'reason' key in error handlers #131

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

michaelborn
Copy link
Contributor

Adds defensive coding for explained cases where a reason is missing from an error response:

Error calling CruiseSearchAPIv1:Search.index: the value from key [REASON]  is NULL, which is the same as not existing in CFML Query: {"query":{"bool":{"filter":{"bool":{"must":[{"term":{"isCruiseTour":false}},{"term":{"region.kw":"Caribbean"}}]}},...

Due to the error in the error handler, I can't even tell where/when this error occurs.

@jclausen jclausen merged commit c07395e into development Feb 20, 2024
1 check passed
@jclausen
Copy link
Contributor

@michaelborn Please add this to the changelog as well, for the next release.

@michaelborn
Copy link
Contributor Author

@michaelborn Please add this to the changelog as well, for the next release.

Cool - I pushed a direct commit: 363eec4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants