Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove peers as a required field in NetworkStatusResponse #103

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Remove peers as a required field in NetworkStatusResponse #103

merged 1 commit into from
Jun 23, 2022

Conversation

racbc
Copy link
Contributor

@racbc racbc commented Jun 23, 2022

Motivation

Some chains don't have peers in /network/status response and the system allows for it to be empty. However, it shows up as required.

Solution

Remove peers from the required fields for NetworkStatusResponse.

@cb-heimdall
Copy link

Review Error for shiatcb @ 2022-06-23 22:34:50 UTC
User must have write permissions to review

shrimalmadhur
shrimalmadhur suggested changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@shrimalmadhur shrimalmadhur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some code is already in master. can you clean up your PR with only your change. THanks

@racbc racbc force-pushed the readme-link-fix branch from 26288ce to f5afd01 Compare June 23, 2022 22:59
@racbc racbc requested a review from shrimalmadhur June 23, 2022 22:59
@shrimalmadhur shrimalmadhur merged commit a660477 into coinbase:master Jun 23, 2022
@racbc racbc deleted the readme-link-fix branch June 23, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrimalmadhur shrimalmadhur shrimalmadhur approved these changes

@shiatcb shiatcb shiatcb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@racbc @cb-heimdall @shrimalmadhur @shiatcb