Fix and improve retry mechanism for Compass client #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corafid
force-pushed
the
corafid/fix/retry-mechanism
branch
from
b5d23ce to
9cd32f2
Compare
luca-cohere
previously approved these changes
Feb 5, 2025
Some APIs, e.g. search APIs, were hard-coding the retry count and sleep time to 1 and 1, respectively. Others, used the DEFAULT_MAX_RETRIES and DEFAULT_SLEEP_RETRY_SECONDS constants, respectively. Yet others allowed passing values from the clients. This PR fixes this as follows: 1. Introduce `default_max_retries` and `default_sleep_retry_seconds` at the client level, which gets applied to all APIs by default. 2. Each API optionally has `max_retries` and `sleep_retry_seconds` parameters that, if specified, will override the default values from the client.
corafid
force-pushed
the
corafid/fix/retry-mechanism
branch
from
5fc8622 to
31457ba
Compare
dbaxter-cohere
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some APIs, e.g. search APIs, were hard-coding the retry count and sleep time to 1 and 1, respectively. Others, used the DEFAULT_MAX_RETRIES and DEFAULT_SLEEP_RETRY_SECONDS constants, respectively. Yet others allowed passing values from the clients. This PR fixes this as follows:
default_max_retriesanddefault_sleep_retry_secondsat the client level, which gets applied to all APIs by default.max_retriesandsleep_retry_secondsparameters that, if specified, will override the default values from the client.