Adjusting fsspec to fix a conflict with other libraries used in load testing #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
javier-cohere
previously approved these changes
Dec 12, 2024
dbaxter-cohere
force-pushed
the
dbaxter/fix_fsspec
branch
from
0c439fa to
f1bfe23
Compare
javier-cohere
previously approved these changes
Dec 12, 2024
|
@dbaxter-cohere , I suggest we also increment the patch version. |
Will do. I have to re-commit anyways with signing enabled |
dbaxter-cohere
force-pushed
the
dbaxter/fix_fsspec
branch
from
f1bfe23 to
2ebcf75
Compare
javier-cohere
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In compass-load-testing we are using datasets library. It has a max version of
2024.9.0and there is not reason we have to require2024.10.0here so I adjusted it so that it shouldn't complain anymore.