Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asset_type into the DocumentChunkAsset struct #63

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

artemiyatcohere
Copy link
Contributor

@artemiyatcohere artemiyatcohere commented Dec 11, 2024

This PR adds the asset_type field to the assets to make it possible to identify what the assets contain.

@artemiyatcohere artemiyatcohere requested a review from a team as a code owner December 11, 2024 21:58
luca-cohere
luca-cohere previously approved these changes Dec 11, 2024
Copy link
Contributor

@benrules3 benrules3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@artemiyatcohere artemiyatcohere merged commit 14514bf into main Dec 13, 2024
11 checks passed
@artemiyatcohere artemiyatcohere deleted the artemiy/add-asset-type-2 branch December 13, 2024 14:41
luca-cohere pushed a commit that referenced this pull request Dec 13, 2024
This PR adds the asset_type field to the assets to make it possible to
identify what the assets contain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants