Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend support for cancellation #35

Open
wants to merge 2 commits into
base: 06-select-a
Choose a base branch
from
Open

Backend support for cancellation #35

wants to merge 2 commits into from

Conversation

willcrichton
Copy link
Contributor

@willcrichton willcrichton commented Aug 23, 2024 •
edited
Loading

Reference solution for cancellation. Key changes:

  • Messages are split into MessagesRequest and MessagesResponse, an enum
  • The chatbot thread now responds with Option<Vec<String>> to represent cancellation
  • The chatbot thread selects between query_chat and a cancellation channel
  • The /cancel route sends a message on the cancellation channel
  • The /chat route handles the case of cancellation

@willcrichton willcrichton force-pushed the 06-select-b branch 2 times, most recently from 3b76150 to ffdbf27 Compare August 26, 2024 21:09
@willcrichton willcrichton changed the title Cancellation solution Backend support for cancellation Aug 26, 2024
@willcrichton willcrichton force-pushed the 06-select-b branch 2 times, most recently from 57a9e35 to 18dd259 Compare September 4, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
06-select
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@willcrichton