Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding specific IndslUserWarning [AH-2555] #93

Merged
merged 7 commits into from
Jan 15, 2024

Conversation

neringaalt
Copy link
Contributor

@neringaalt neringaalt commented Jan 8, 2024

Description

adding specific IndslUserWarning such that it would be easy for backend to know if the warning comes from Indsl and it should be shown to the user, or that it should be ignored.

Motivation and Context

Currently we do not have ability to check if warning comes from the 3rd source API or Indsl. With this change we will be able to show only warnings that comes from Indsl to the user.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Contributor Checklist:

  • My code follows the code style of this project.
  • I have added an example of my new feature and included it in the documentation.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My Pull Request name follows the naming convention fix: <description>, feat: <description>, etc.

Reviewer Checklist for Charts compliant functions:

  • The docstrings of the new function follow the contributing guidelines.
  • The new function is professionally documented
  • The new function and associated scripts are covered by one or more unit tests and code coverage did not decrease.
  • The new function is accompanied by an example and it is included in the Gallery of Charts.
  • The new function is reviewed in Chromatic. Access the storybook build results url and comment, approve or deny.
  • All function inputs, arguments, and outputs have a supported data type and have human readable names.
  • No code language is included in the description of the function or parameters (e.g use "polynomial order" instead of "poly_order")

… for backend to know if the warning comes from Indsl and it should be shown to the user, or that it should be ignored.
@neringaalt neringaalt requested review from a team and MortGron January 8, 2024 14:26
@neringaalt neringaalt changed the title [AH-2555] adding specific IndslUserWarning feat: adding specific IndslUserWarning [AH-2555] Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Merging #93 (5778815) into main (292d34a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   91.22%   91.23%   +0.01%     
==========================================
  Files         103      104       +1     
  Lines        3770     3778       +8     
  Branches      815      815              
==========================================
+ Hits         3439     3447       +8     
  Misses        207      207              
  Partials      124      124              
Files Coverage Δ
indsl/equipment/volume_vessel.py 79.72% <100.00%> (+0.27%) ⬆️
indsl/resample/interpolate.py 95.45% <100.00%> (+0.10%) ⬆️
indsl/resample/resample.py 91.93% <100.00%> (+0.13%) ⬆️
indsl/resample/resample_v1.py 54.16% <100.00%> (+0.64%) ⬆️
indsl/signals/generator.py 83.33% <100.00%> (+0.08%) ⬆️
indsl/statistics/outliers_v1.py 84.70% <100.00%> (+0.18%) ⬆️
indsl/ts_utils/ts_utils.py 95.94% <100.00%> (+0.02%) ⬆️
indsl/warnings.py 100.00% <100.00%> (ø)

Copy link

github-actions bot commented Jan 8, 2024

Unit Test Results

    21 files  ±0      21 suites  ±0   54m 43s ⏱️ ±0s
 1 090 tests ±0   1 090 ✅ ±0   0 💤 ±0  0 ❌ ±0 
15 402 runs  ±0  15 390 ✅ ±0  12 💤 ±0  0 ❌ ±0 

Results for commit 5778815. ± Comparison against base commit 292d34a.

♻️ This comment has been updated with latest results.

@neringaalt neringaalt requested a review from dbrattli January 8, 2024 14:51
removing pass

Co-authored-by: Dag Brattli <[email protected]>
@neringaalt neringaalt requested a review from dbrattli January 9, 2024 11:48
Copy link
Contributor

@dbrattli dbrattli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dbrattli dbrattli added the auto-update Bulldozer automatically rebase a PR label Jan 9, 2024
@neringaalt neringaalt merged commit 898799c into main Jan 15, 2024
@neringaalt neringaalt deleted the making_indsl_user_warnings branch January 15, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Bulldozer automatically rebase a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants