Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing recommended python version #75

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

neringaalt
Copy link
Contributor

@neringaalt neringaalt commented Dec 14, 2023

Description

Removing recommended python version and updating contribution guidelines

Motivation and Context

Improving contribution guidelines

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Contributor Checklist:

  • My code follows the code style of this project.
  • I have added an example of my new feature and included it in the documentation.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My Pull Request name follows the naming convention fix: <description>, feat: <description>, etc.

Reviewer Checklist for Charts compliant functions:

  • The docstrings of the new function follow the contributing guidelines.
  • The new function is professionally documented
  • The new function and associated scripts are covered by one or more unit tests and code coverage did not decrease.
  • The new function is accompanied by an example and it is included in the Gallery of Charts.
  • The new function is reviewed in Chromatic. Access the storybook build results url and comment, approve or deny.
  • All function inputs, arguments, and outputs have a supported data type and have human readable names.
  • No code language is included in the description of the function or parameters (e.g use "polynomial order" instead of "poly_order")

@neringaalt neringaalt requested review from a team, MortGron and dbrattli December 14, 2023 14:57
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #75 (44453cc) into main (8af4cea) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files         103      103           
  Lines        3770     3770           
  Branches      815      815           
=======================================
  Hits         3439     3439           
  Misses        207      207           
  Partials      124      124           

Copy link

Unit Test Results

       21 files  ±0         21 suites  ±0   51m 55s ⏱️ - 1m 38s
  1 090 tests ±0    1 090 ✔️ ±0  0 💤 ±0  0 ±0 
15 402 runs  ±0  15 393 ✔️ ±0  9 💤 ±0  0 ±0 

Results for commit 44453cc. ± Comparison against base commit 8af4cea.

@neringaalt neringaalt requested a review from a team December 14, 2023 15:26
@neringaalt neringaalt merged commit 1108b36 into main Dec 14, 2023
@neringaalt neringaalt deleted the fix_removing_python_version branch December 14, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants