-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Switch back function descriptions #72
Conversation
… Simple moving average
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 91.22% 91.22%
=======================================
Files 103 103
Lines 3770 3770
Branches 815 815
=======================================
Hits 3439 3439
Misses 207 207
Partials 124 124 |
…dsl into vebjorn/fix-switched-desc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation is auto generated, you should not need to change HTML for it.
The mistake is in the rst
file where you specify how to generate documentation.
Look at docs-source/source/smooth.rst
, there you can see that wrong names are defined.
This is described here https://indsl.docs.cognite.com/contribute.html#document-your-algorithm
Please add the Jira ticket as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The function descriptions of Linear weighted moving average and Simple moving average had switched the places, so this bugfix places them where they belong.
Jira ticket
Motivation and Context
Functions in InDSL should have correct descriptions.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Contributor Checklist:
fix: <description>
,feat: <description>
, etc.Reviewer Checklist for Charts compliant functions: