Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: python-3.12 #6

Merged
merged 9 commits into from
Nov 16, 2023
Merged

feat: python-3.12 #6

merged 9 commits into from
Nov 16, 2023

Conversation

dbrattli
Copy link
Contributor

@dbrattli dbrattli commented Oct 10, 2023

Description

Motivation and Context

Add support for using InDSL with Python 3.12

How Has This Been Tested?

Running existing tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Contributor Checklist:

  • My code follows the code style of this project.
  • I have added an example of my new feature and included it in the documentation.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My Pull Request name follows the naming convention fix: <description>, feat: <description>, etc.

Reviewer Checklist for Charts compliant functions:

  • The docstrings of the new function follow the contributing guidelines.
  • The new function is professionally documented
  • The new function and associated scripts are covered by one or more unit tests and code coverage did not decrease.
  • The new function is accompanied by an example and it is included in the Gallery of Charts.
  • The new function is reviewed in Chromatic. Access the storybook build results url and comment, approve or deny.
  • All function inputs, arguments, and outputs have a supported data type and have human readable names.
  • No code language is included in the description of the function or parameters (e.g use "polynomial order" instead of "poly_order")

@dbrattli dbrattli requested review from a team and redzaroslii October 10, 2023 13:32
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 4623252. ± Comparison against base commit 32838a3.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #6 (8f4c5bb) into main (56788ae) will increase coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   91.14%   91.22%   +0.07%     
==========================================
  Files         103      103              
  Lines        3770     3770              
  Branches      815      815              
==========================================
+ Hits         3436     3439       +3     
  Misses        207      207              
+ Partials      127      124       -3     

see 3 files with indirect coverage changes

@github-actions
Copy link

@dbrattli dbrattli added auto-merge Bulldozer auto-merge auto-update Bulldozer automatically rebase a PR labels Nov 16, 2023
@cognite-bulldozer cognite-bulldozer bot merged commit 98a7bec into main Nov 16, 2023
@cognite-bulldozer cognite-bulldozer bot deleted the python-3.12 branch November 16, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Bulldozer auto-merge auto-update Bulldozer automatically rebase a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants