Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrected types #31

Merged
merged 4 commits into from
Oct 24, 2023
Merged

fix: corrected types #31

merged 4 commits into from
Oct 24, 2023

Conversation

anvar-akhiiartdinov
Copy link
Contributor

@anvar-akhiiartdinov anvar-akhiiartdinov commented Oct 18, 2023

Corrected data types for shutin function

Description

Correct types from int to float

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Contributor Checklist:

  • My code follows the code style of this project.
  • I have added an example of my new feature and included it in the documentation.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My Pull Request name follows the naming convention fix: <description>, feat: <description>, etc.

Reviewer Checklist for Charts compliant functions:

  • The docstrings of the new function follow the contributing guidelines.
  • The new function is professionally documented
  • The new function and associated scripts are covered by one or more unit tests and code coverage did not decrease.
  • The new function is accompanied by an example and it is included in the Gallery of Charts.
  • The new function is reviewed in Chromatic. Access the storybook build results url and comment, approve or deny.
  • All function inputs, arguments, and outputs have a supported data type and have human readable names.
  • No code language is included in the description of the function or parameters (e.g use "polynomial order" instead of "poly_order")

@anvar-akhiiartdinov anvar-akhiiartdinov requested review from a team and Anitsirc22 October 18, 2023 20:44
@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit f250d7f. ± Comparison against base commit 8c7bb5f.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #31 (f250d7f) into main (8c7bb5f) will decrease coverage by 18.36%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #31       +/-   ##
===========================================
- Coverage   91.14%   72.78%   -18.36%     
===========================================
  Files         103      103               
  Lines        3770     3770               
  Branches      815      538      -277     
===========================================
- Hits         3436     2744      -692     
- Misses        207      893      +686     
- Partials      127      133        +6     
Files Coverage Δ
indsl/oil_and_gas/shut_in_detector.py 93.22% <ø> (-3.39%) ⬇️

... and 38 files with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

@anvar-akhiiartdinov anvar-akhiiartdinov changed the title corrected types fix: corrected types Oct 19, 2023
Copy link
Contributor

@Anitsirc22 Anitsirc22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anitsirc22 Anitsirc22 added the auto-merge Bulldozer auto-merge label Oct 24, 2023
@cognite-bulldozer cognite-bulldozer bot merged commit 02388e3 into main Oct 24, 2023
@cognite-bulldozer cognite-bulldozer bot deleted the shutin-patch branch October 24, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Bulldozer auto-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants