Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interpolation based on sequence data #277

Merged
merged 12 commits into from
Aug 26, 2024

Conversation

gunnarstaff
Copy link
Contributor

@gunnarstaff gunnarstaff commented Aug 2, 2024

Description

1D and 2D Interpolation routine where the interpolation parameters are provided as a sequence while the input parameters are time series

Motivation and Context

Today it is very cumbersome to calculate a response where the "function" is based on a tabular input. Examples of applications would be choke CV curve, pump performance curve, fluid properties etc

How Has This Been Tested?

Test function for both 1d and 2d method
Tested on windows 11, python 3.10.7
No effect on other functions

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Contributor Checklist:

  • My code follows the code style of this project.
  • I have added an example of my new feature and included it in the documentation.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My Pull Request name follows the naming convention fix: <description>, feat: <description>, etc.

Reviewer Checklist for Charts compliant functions:

  • The docstrings of the new function follow the contributing guidelines.
  • The new function is professionally documented
  • The new function and associated scripts are covered by one or more unit tests and code coverage did not decrease.
  • The new function is accompanied by an example and it is included in the Gallery of Charts.
  • The new function is reviewed in Chromatic. Access the storybook build results url and comment, approve or deny.
  • All function inputs, arguments, and outputs have a supported data type and have human readable names.
  • No code language is included in the description of the function or parameters (e.g use "polynomial order" instead of "poly_order")

@gunnarstaff gunnarstaff requested review from a team and neringaalt August 2, 2024 11:56
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 76.31579% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.14%. Comparing base (673cc33) to head (8fe9f23).
Report is 1 commits behind head on main.

Files Patch % Lines
indsl/signals/sequence_interpolation.py 75.67% 4 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   91.28%   91.14%   -0.15%     
==========================================
  Files         107      108       +1     
  Lines        3891     3929      +38     
  Branches      845      852       +7     
==========================================
+ Hits         3552     3581      +29     
- Misses        208      212       +4     
- Partials      131      136       +5     
Files Coverage Δ
indsl/signals/__init__.py 100.00% <100.00%> (ø)
indsl/signals/sequence_interpolation.py 75.67% <75.67%> (ø)

Copy link

github-actions bot commented Aug 2, 2024

Unit Test Results

    15 files  ± 0      15 suites  ±0   26m 34s ⏱️ +29s
 1 122 tests + 5   1 122 ✅ + 5  0 💤 ±0  0 ❌ ±0 
11 079 runs  +57  11 071 ✅ +58  8 💤  - 1  0 ❌ ±0 

Results for commit 8fe9f23. ± Comparison against base commit 673cc33.

♻️ This comment has been updated with latest results.

@VebjornG VebjornG merged commit 87eb6a0 into main Aug 26, 2024
25 checks passed
@VebjornG VebjornG deleted the gstaff/non_timeseries_interpolation branch August 26, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants