Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot find function version [AH-1526] #26

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

Anitsirc22
Copy link
Contributor

@Anitsirc22 Anitsirc22 commented Oct 17, 2023

check_types decorator should be placed before versioning.register so that custom attributes are kept in the versioned function

@Anitsirc22 Anitsirc22 requested review from a team and HaydenCognite October 17, 2023 13:44
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 1490efa. ± Comparison against base commit a8b5d91.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #26 (1490efa) into main (a8b5d91) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files         103      103           
  Lines        3770     3770           
  Branches      815      815           
=======================================
  Hits         3436     3436           
  Misses        207      207           
  Partials      127      127           
Files Coverage Δ
indsl/smooth/butterworth.py 100.00% <100.00%> (ø)
indsl/smooth/butterworth_v1.py 100.00% <100.00%> (ø)
indsl/ts_utils/numerical_calculus.py 90.27% <100.00%> (ø)
indsl/ts_utils/numerical_calculus_v1.py 92.59% <100.00%> (ø)

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

neringaalt
neringaalt previously approved these changes Oct 17, 2023
Copy link
Contributor

@neringaalt neringaalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, good catch! Can we add it to contribution guidelines?

@Anitsirc22 Anitsirc22 added the auto-merge Bulldozer auto-merge label Oct 24, 2023
@cognite-bulldozer cognite-bulldozer bot merged commit 6cb0d0c into main Oct 24, 2023
@cognite-bulldozer cognite-bulldozer bot deleted the AH-1526_fix_function_versioning branch October 24, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Bulldozer auto-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants