Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable oscillation detection in charts #240

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

VebjornG
Copy link
Contributor

@VebjornG VebjornG commented Jun 5, 2024

Description

Oscillation detection is failing due to the use of frequencies as indices so for now the function is being disabled in charts.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Contributor Checklist:

  • My code follows the code style of this project.
  • I have added an example of my new feature and included it in the documentation.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My Pull Request name follows the naming convention fix: <description>, feat: <description>, etc.

Reviewer Checklist for Charts compliant functions:

  • The docstrings of the new function follow the contributing guidelines.
  • The new function is professionally documented
  • The new function and associated scripts are covered by one or more unit tests and code coverage did not decrease.
  • The new function is accompanied by an example and it is included in the Gallery of Charts.
  • The new function is reviewed in Chromatic. Access the storybook build results url and comment, approve or deny.
  • All function inputs, arguments, and outputs have a supported data type and have human readable names.
  • No code language is included in the description of the function or parameters (e.g use "polynomial order" instead of "poly_order")

@VebjornG VebjornG requested review from a team and neringaalt June 5, 2024 08:27
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (bc9cbe8) to head (a6edd75).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         105      105           
  Lines        3849     3849           
  Branches      836      836           
=======================================
  Hits         3514     3514           
  Misses        207      207           
  Partials      128      128           
Files Coverage Δ
indsl/detect/__init__.py 100.00% <ø> (ø)

Copy link

github-actions bot commented Jun 5, 2024

Unit Test Results

    21 files  ±0      21 suites  ±0   37m 17s ⏱️ +50s
 1 108 tests  - 1   1 108 ✅  - 1   0 💤 ±0  0 ❌ ±0 
15 720 runs   - 9  15 709 ✅  - 9  11 💤 ±0  0 ❌ ±0 

Results for commit a6edd75. ± Comparison against base commit bc9cbe8.

This pull request removes 1 test.
tests.test_docstrings ‑ test_docstrings_are_valid[oscillation_detector]

@VebjornG VebjornG merged commit 1185035 into main Jun 5, 2024
31 checks passed
@VebjornG VebjornG deleted the vebjorn/disable-oscillation-detection branch June 5, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants