Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing pytest dependencies [AH-3056] #197

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

neringaalt
Copy link
Contributor

@neringaalt neringaalt commented Apr 17, 2024

Description

Pytest >8.0.0 is failing due to restructure of modules and packages
Have moved out Indsl import to conftest to fix it.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Contributor Checklist:

  • My code follows the code style of this project.
  • I have added an example of my new feature and included it in the documentation.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My Pull Request name follows the naming convention fix: <description>, feat: <description>, etc.

Reviewer Checklist for Charts compliant functions:

  • The docstrings of the new function follow the contributing guidelines.
  • The new function is professionally documented
  • The new function and associated scripts are covered by one or more unit tests and code coverage did not decrease.
  • The new function is accompanied by an example and it is included in the Gallery of Charts.
  • The new function is reviewed in Chromatic. Access the storybook build results url and comment, approve or deny.
  • All function inputs, arguments, and outputs have a supported data type and have human readable names.
  • No code language is included in the description of the function or parameters (e.g use "polynomial order" instead of "poly_order")

@neringaalt neringaalt requested review from a team and MortGron April 17, 2024 12:14
@neringaalt neringaalt changed the title Neri/fixing dependencies chore: fixing pytest dependencies Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Merging #197 (7c1bd96) into main (2e53cdf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         105      105           
  Lines        3839     3839           
  Branches      832      832           
=======================================
  Hits         3501     3501           
  Misses        209      209           
  Partials      129      129           

Copy link

Unit Test Results

    21 files  +    4      21 suites  +4   53m 58s ⏱️ + 19m 15s
 1 103 tests ±    0   1 103 ✅ ±    0   0 💤 ±0  0 ❌ ±0 
15 651 runs  +3 274  15 639 ✅ +3 270  12 💤 +4  0 ❌ ±0 

Results for commit 7c1bd96. ± Comparison against base commit 2e53cdf.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.
tests.test_docstrings ‑ test_docstrings_are_valid[arctan20]
tests.test_docstrings ‑ test_docstrings_are_valid[arctan21]
tests.test_docstrings ‑ test_docstrings_are_valid[log100]
tests.test_docstrings ‑ test_docstrings_are_valid[log101]
tests.test_docstrings ‑ test_docstrings_are_valid[log20]
tests.test_docstrings ‑ test_docstrings_are_valid[log21]
tests.test_docstrings ‑ test_docstrings_are_valid[arctan2_0]
tests.test_docstrings ‑ test_docstrings_are_valid[arctan2_1]
tests.test_docstrings ‑ test_docstrings_are_valid[log10_0]
tests.test_docstrings ‑ test_docstrings_are_valid[log10_1]
tests.test_docstrings ‑ test_docstrings_are_valid[log2_0]
tests.test_docstrings ‑ test_docstrings_are_valid[log2_1]

@neringaalt neringaalt requested a review from VebjornG April 17, 2024 13:23
@neringaalt neringaalt changed the title chore: fixing pytest dependencies chore: fixing pytest dependencies [AH-3056] Apr 17, 2024
@neringaalt neringaalt merged commit 57a3f46 into main Apr 17, 2024
32 checks passed
@neringaalt neringaalt deleted the neri/fixing_dependencies branch April 17, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants