-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [AH-3049] Open source contributions documentation #184
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
=======================================
Coverage 91.37% 91.37%
=======================================
Files 105 105
Lines 3837 3837
Branches 832 832
=======================================
Hits 3506 3506
Misses 206 206
Partials 125 125 |
…dsl into vebjorn/open-source-contr
docs-source/source/contribute.rst
Outdated
Make sure that they pass. | ||
|
||
5. **Make a pull request**: Once you are satisfied with your changes and all of the tests pass, make a pull request to | ||
the main repository using the conventional commit message format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a link to indsl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That link is at the top of the "Contributing" section though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be confusing to know what we mean by "main repository"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then i think it's better to change the wording here
@VebjornG could you fix all the places in the documentation where it says that repository should be cloned? We need to make sure that it should be done by forking repo for open source contributions, but Cognite people could clone it directly. Could you figure out how to phrase those sentences? Maybe with links for the open source contributions? |
Made a suggestion in the latest commit 👍🏻 |
Since InDSL is generally available it should have documentation covering open source contributions. This PR aims to provide that.
Ticket