chore: push json to private project #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 105 105
Lines 3803 3803
Branches 821 821
=======================================
Hits 3473 3473
Misses 206 206
Partials 124 124
|
…nto vebjorn/test-project
|
With that limitation, I think we should change the key generation to exclude |
That is done already: |
neringaalt
reviewed
Feb 19, 2024
| @@ -18,6 +20,10 @@ | |||
| TOOLBOX_NAME = "TOOLBOX_NAME" | |||
| COGNITE = "__cognite__" | |||
|
|
|||
| LOCIZE_API_KEY = os.getenv("LOCIZE_API_KEY") | |||
There was a problem hiding this comment.
Is this working with github action secrets?
There was a problem hiding this comment.
the action actually mounts the secret as environment variables. So it should work and is tested
There was a problem hiding this comment.
pyproject.toml
Outdated
| @@ -29,6 +29,7 @@ csaps = { version = "^1.1.0", optional = true } | |||
| statsmodels = { version = "^0.14.0", optional = true } | |||
| scikit-image = { version = "^0.21.0", optional = true } | |||
| scikit-learn = { version = "^1.3.0", optional = true } | |||
| requests = "^2.31.0" | |||
There was a problem hiding this comment.
we dont' need this I suppose.
tuanng-cognite
previously approved these changes
Feb 20, 2024
tuanng-cognite
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a script that creates a json file with keys and values from the docstrings of the functions in InDSL and compares them to the source of truth in Locize. If any changes have been made they will be pushed to Locize, replacing the old ones. The script is used in the workflow
push-locize.yamlwhich is run when translations are needed for widespread use of InDSL. We use e.g...._1_0as versions for the versioned functions rather than"..._1.0"because Locize will treat any key name with a dot as an array an split the key name at the dot: locize/locize-cli#23. An example of from the raw output from Locize with_1.0as the versioning number is:"INDSL_DETECT_OUTLIERS_1": { "0_": "Outlier detection" },Ticket