Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Publishing locize action #111

Merged
merged 45 commits into from
Feb 2, 2024
Merged

chore: Publishing locize action #111

merged 45 commits into from
Feb 2, 2024

Conversation

neringaalt
Copy link
Contributor

@neringaalt neringaalt commented Jan 31, 2024

Description

Introduces changes to github action

Motivation and Context

Translation key-values should be published to Locize project before each release

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Contributor Checklist:

  • My code follows the code style of this project.
  • I have added an example of my new feature and included it in the documentation.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My Pull Request name follows the naming convention fix: <description>, feat: <description>, etc.

Reviewer Checklist for Charts compliant functions:

  • The docstrings of the new function follow the contributing guidelines.
  • The new function is professionally documented
  • The new function and associated scripts are covered by one or more unit tests and code coverage did not decrease.
  • The new function is accompanied by an example and it is included in the Gallery of Charts.
  • The new function is reviewed in Chromatic. Access the storybook build results url and comment, approve or deny.
  • All function inputs, arguments, and outputs have a supported data type and have human readable names.
  • No code language is included in the description of the function or parameters (e.g use "polynomial order" instead of "poly_order")

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Merging #111 (c373991) into main (c7842cf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         105      105           
  Lines        3802     3802           
  Branches      821      821           
=======================================
  Hits         3470     3470           
  Misses        207      207           
  Partials      125      125           

Copy link

github-actions bot commented Jan 31, 2024

Unit Test Results

    21 files  ±0      21 suites  ±0   54m 40s ⏱️ - 1m 44s
 1 091 tests ±0   1 091 ✅ ±0   0 💤 ±0  0 ❌ ±0 
15 411 runs  ±0  15 400 ✅ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit c373991. ± Comparison against base commit c7842cf.

♻️ This comment has been updated with latest results.

@neringaalt neringaalt changed the title Publishing locize action chore: Publishing locize action Feb 2, 2024
@neringaalt neringaalt marked this pull request as ready for review February 2, 2024 11:09
@neringaalt neringaalt requested review from a team, redzaroslii and VebjornG and removed request for redzaroslii February 2, 2024 11:09
Copy link
Contributor

@VebjornG VebjornG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@neringaalt neringaalt merged commit 3ca7ed1 into main Feb 2, 2024
@neringaalt neringaalt deleted the publishing_locize_action branch February 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants