-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create a script that makes a json file with key value pairs for translations #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 91.23% 91.26% +0.02%
==========================================
Files 104 105 +1
Lines 3778 3802 +24
Branches 815 821 +6
==========================================
+ Hits 3447 3470 +23
Misses 207 207
- Partials 124 125 +1
|
…o vebjorn/add-script
neringaalt
reviewed
Jan 25, 2024
neringaalt
reviewed
Jan 25, 2024
neringaalt
reviewed
Jan 25, 2024
neringaalt
reviewed
Jan 25, 2024
neringaalt
reviewed
Jan 25, 2024
neringaalt
reviewed
Jan 26, 2024
neringaalt
requested changes
Jan 29, 2024
neringaalt
reviewed
Jan 29, 2024
neringaalt
previously approved these changes
Jan 30, 2024
Good job! :) |
neringaalt
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are translating the information from the docstrings in the functions in InDSL so that they can be displayed in different languages in Charts. In this workflow a script that takes the docstrings and singles out the relevant fields with the correct keys and thereafter places them in a JSON file is needed.
Ticket
How Has This Been Tested?
A test that writes to a JSON file in order to check that the output of the parsed docstring is correct is included in this PR.
Screenshots (if appropriate):
Types of changes
Contributor Checklist:
fix: <description>
,feat: <description>
, etc.Reviewer Checklist for Charts compliant functions: