Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate support for python 3.8 [AH-1078] #10

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

Anitsirc22
Copy link
Contributor

Supporting a large number of Python versions has a high maintenance cost, and some dependencies may require higher versions.

We shouldn’t support more than 2 major versions i.e 3.9 and 3.10.

Note that any customers still using Python 3.8 will NOT be broken by this if we bump the major version (as we should). They can continue to use the old library and upgrade when ready. Getting new features can also be a good motivation.

Python 3.8 will end-of-life in October 2024. So there’s still some time until we have to remove it. PEP 569 – Python 3.8 Release Schedule | peps.python.org

@Anitsirc22 Anitsirc22 requested review from a team and neringaalt October 11, 2023 11:03
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 2ddcef5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

@dbrattli
Copy link
Contributor

PS: Remember to remove 3.8 from matrix testing in CI

Copy link
Contributor

@dbrattli dbrattli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@1458e15). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage        ?   72.75%           
=======================================
  Files           ?      103           
  Lines           ?     3770           
  Branches        ?      815           
=======================================
  Hits            ?     2743           
  Misses          ?      893           
  Partials        ?      134           

@Anitsirc22 Anitsirc22 added the auto-merge Bulldozer auto-merge label Oct 12, 2023
@cognite-bulldozer cognite-bulldozer bot merged commit 573b53d into main Oct 12, 2023
@cognite-bulldozer cognite-bulldozer bot deleted the cft/deprecate_support_python_3.8 branch October 12, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Bulldozer auto-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants