-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate support for python 3.8 [AH-1078] #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chromatic Results
|
PS: Remember to remove 3.8 from matrix testing in CI |
dbrattli
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage ? 72.75%
=======================================
Files ? 103
Lines ? 3770
Branches ? 815
=======================================
Hits ? 2743
Misses ? 893
Partials ? 134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting a large number of Python versions has a high maintenance cost, and some dependencies may require higher versions.
We shouldn’t support more than 2 major versions i.e 3.9 and 3.10.
Note that any customers still using Python 3.8 will NOT be broken by this if we bump the major version (as we should). They can continue to use the old library and upgrade when ready. Getting new features can also be a good motivation.
Python 3.8 will end-of-life in October 2024. So there’s still some time until we have to remove it. PEP 569 – Python 3.8 Release Schedule | peps.python.org