Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert event date fields from integer to date objects #354

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

sagar-thalwar
Copy link
Contributor

Problem / User story
Customers complaining that Event data's date fields are represented as integer values rather than in Date format.

Solution
Convert Event data's createdTime, lastUpdatedTime, startTime, endTime to Date object

Affected Resource types
What resource types has been involved in the change? Events

Changes to datasource JSON model
What has been updated in the JSON? Any fields added/removed, possible breaking changes?
No

Has documentation been updated
Yes/No

Have tests been updated?
Yes

Screenshots and examples
Screenshots and example query if applicable
Screenshot 2024-03-13 at 14 51 40

@sagar-thalwar sagar-thalwar requested a review from a team March 13, 2024 13:51
Copy link
Contributor

@polomani polomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, could you bump the plugin version in the package.json?

Copy link
Contributor

@polomani polomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged I can show on how to release the version via grafana.com

@sagar-thalwar sagar-thalwar merged commit 107fedb into master Mar 14, 2024
3 checks passed
@sagar-thalwar sagar-thalwar deleted the POFSP-361 branch March 14, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants