Added lodash to clone reference options #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
added a commit
that referenced
this pull request
May 4, 2015
Added lodash to clone reference options
|
Thanks |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So yesterday I was pulling my hair out: why the hell were my Karma config options changing when I ran
gulp-karmabefore I then rangulp-webpackwith the same options object. I then dived into this code and saw that the object arguments being passed are being manipulated. Super sad times.So what I've done is simply used lodash's
_.cloneso that this plugin's magic doesn't mess with my magic and we're all happy; I hope that's ok.