Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#53 Added OR operator support #74

Merged
merged 1 commit into from
Mar 18, 2016

Conversation

partikus
Copy link
Contributor

@defrag @norzechowicz code review please

any advices welcome

@partikus partikus mentioned this pull request Mar 14, 2016
@norberttech
Copy link
Member

@partikus could you please add some tests of this or matcher also here: https://github.com/coduo/php-matcher/blob/master/tests/MatcherTest.php ? Just to be sure that everything works fine with Facade

@partikus partikus force-pushed the feature/or-matcher branch from bc121bc to d7bae23 Compare March 17, 2016 22:39
@partikus
Copy link
Contributor Author

@norzechowicz I just changed it, I replaced manual build with factory, is it ok?
https://github.com/coduo/php-matcher/pull/74/files#diff-9239b5179e155b531c87cd180c1f4966R19

@partikus partikus force-pushed the feature/or-matcher branch from d7bae23 to 9a2c879 Compare March 17, 2016 22:55
@partikus partikus changed the title #53 Added OR operator support [WIP] #53 Added OR operator support Mar 17, 2016
@partikus partikus force-pushed the feature/or-matcher branch from 9a2c879 to 3603c08 Compare March 17, 2016 22:57
@partikus partikus changed the title [WIP] #53 Added OR operator support #53 Added OR operator support Mar 17, 2016
@partikus partikus force-pushed the feature/or-matcher branch from 3603c08 to 4a2dbe1 Compare March 17, 2016 23:01
@norberttech
Copy link
Member

@partikus yea, its fine, thanks!

norberttech pushed a commit that referenced this pull request Mar 18, 2016
@norberttech norberttech merged commit 63de6d2 into coduo:master Mar 18, 2016
@partikus partikus deleted the feature/or-matcher branch February 15, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants