Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isUrl() pattern expander #51

Merged
merged 1 commit into from
Feb 22, 2015
Merged

Add isUrl() pattern expander #51

merged 1 commit into from
Feb 22, 2015

Conversation

rpalladino
Copy link
Contributor

This adds an isUrl() expander with a test case. Like the isEmail() expander, upon which it is based, it handles validation using the PHP filter extension.

@norberttech
Copy link
Member

Thanks @rpalladino!
Could you please also add one example into tests/Coduo/PHPMatcher/MatcherTest.php to expanderExamples method? It's an integration test just to be sure that all expanders are initialized.

This adds an isUrl() expander with a test case. Like the isEmail() expander, upon which it is based, it handles validation using the PHP filter extension.
@rpalladino
Copy link
Contributor Author

Missed that one. I added two examples, one that should be true and one false.

norberttech pushed a commit that referenced this pull request Feb 22, 2015
Add isUrl() pattern expander
@norberttech norberttech merged commit 51f48df into coduo:master Feb 22, 2015
@norberttech
Copy link
Member

@rpalladino thanks a lot! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants