Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Repeat expander in JSON Context #151

Merged
merged 6 commits into from
Apr 26, 2019
Merged

Conversation

JarJak
Copy link
Contributor

@JarJak JarJak commented Apr 18, 2019

Fixes #150

@norberttech
Copy link
Member

Hey @JarJak looks good but could you please add test with example of repeat expander usage that wasn't working previously?

@JarJak
Copy link
Contributor Author

JarJak commented Apr 20, 2019

@norzechowicz sure! Can you guide me how to test if an expander works fine with JsonMatcher?

@norberttech
Copy link
Member

Maybe try from testing example that wasn't working for you in #150

"@[email protected]({"name": "@string@", "value": "@array@"})"

This one should works now, right?

@JarJak
Copy link
Contributor Author

JarJak commented Apr 21, 2019

@norzechowicz no, this is not a valid JSON. This one should work:

"@[email protected]({\"name\": \"@string@\", \"value\": \"@array@\"})"

@norberttech
Copy link
Member

@JarJak I was more thining about adding those tests into this PR so it could actually prove that your fix works :P Could you merge those two?

@JarJak
Copy link
Contributor Author

JarJak commented Apr 26, 2019

@norzechowicz they are merged... see changes in this PR

@norberttech norberttech merged commit 5ff1924 into coduo:master Apr 26, 2019
@norberttech
Copy link
Member

right cool thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't make array Repeat expander working in JSON context
2 participants