Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to use expanders for multiple matchers #105

Merged
merged 4 commits into from
Oct 14, 2017

Conversation

SpartakusMd
Copy link
Contributor

@SpartakusMd SpartakusMd commented Aug 18, 2017

Following matchers coulnd't have expanders :

  • BooleanMatcher
  • NumberMatcher
  • UuidMatcher

@SpartakusMd
Copy link
Contributor Author

P.S. @norzechowicz can I ask you to tag a new release in order to not use dev-master in composer ?

@norberttech
Copy link
Member

norberttech commented Aug 19, 2017

hey @SpartakusMd thanks for your contribution, it looks useful!
Could you please add usage of those expanders into tests?
Also what use case do you have for adding expanders into null & boolean matchers?

About releasing stable version, first I would like to merge all PR for 3.0.0 milestone. Then I will update my personal project dependencies and then I should be able to release 3.0.0

@norberttech norberttech added this to the 3.0.0 milestone Aug 19, 2017
@SpartakusMd
Copy link
Contributor Author

@norzechowicz, for null matcher I don't have a use for the expanders, but I considered it's better to have the possibility to have the expanders and like so all the matchers are more similar.

For the boolean matcher I use the optional expander. We do functional API tests, and have a model that is extended and when you need to test an API that can return one variant of the extended model you should have the ability to mark some fields as optional.

I'll add the tests when I'll have some time.

@norberttech
Copy link
Member

for null matcher I don't have a use for the expanders, but I considered it's better to have the possibility to have the expanders and like so all the matchers are more similar

So please remove it, adding this possibility also means it needs to be supported as long as version 3.0.0 will be supported.

I'll add the tests when I'll have some time.

Thanks!

- BooleanMatcher
- NullMatcher
- NumberMatcher
- UuidMatcher
@SpartakusMd
Copy link
Contributor Author

@norzechowicz I added some tests. Should I add more ?

@norberttech norberttech merged commit 9623632 into coduo:master Oct 14, 2017
@norberttech
Copy link
Member

Hey @SpartakusMd looks good, thanks! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants