-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to use expanders for multiple matchers #105
Conversation
P.S. @norzechowicz can I ask you to tag a new release in order to not use dev-master in composer ? |
hey @SpartakusMd thanks for your contribution, it looks useful! About releasing stable version, first I would like to merge all PR for 3.0.0 milestone. Then I will update my personal project dependencies and then I should be able to release 3.0.0 |
@norzechowicz, for null matcher I don't have a use for the expanders, but I considered it's better to have the possibility to have the expanders and like so all the matchers are more similar. For the boolean matcher I use the optional expander. We do functional API tests, and have a model that is extended and when you need to test an API that can return one variant of the extended model you should have the ability to mark some fields as optional. I'll add the tests when I'll have some time. |
So please remove it, adding this possibility also means it needs to be supported as long as version 3.0.0 will be supported.
Thanks! |
- BooleanMatcher - NullMatcher - NumberMatcher - UuidMatcher
@norzechowicz I added some tests. Should I add more ? |
Hey @SpartakusMd looks good, thanks! 🍻 |
Following matchers coulnd't have expanders :