Provide Open Graph metadata for Quotes (#170) #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supported fields: - og:title - og:type (with custom loglist:quote type) - og:image - og:description - og:url
|
Thanks, looks good to me. Will deploy. |
|
|
||
| @entity(s"Log List ⚙ Цитата #${quote.id}", | ||
| "loglist:quote", | ||
| routes.Assets.at("images/gear_400x400.png").absoluteURL(), |
There was a problem hiding this comment.
Why don't we provide two images—the original in SVG and a fallback in PNG?
There was a problem hiding this comment.
It seems we could: http://opengraphprotocol.org/#array
There was a problem hiding this comment.
Nah, too much of an effort. Let's create a separate issue for that and implement it if it's really needed.
There was a problem hiding this comment.
I meant I'll research and not create a PR for that because of reasons.
| @@ -0,0 +1,7 @@ | |||
| @(quote: models.data.Quote)(implicit requestHeader: play.api.mvc.RequestHeader) | |||
|
|
|||
| @entity(s"Log List ⚙ Цитата #${quote.id}", | |||
There was a problem hiding this comment.
We use “№” in RSS but “#” here and on the web. Shouldn't it be consistent?
There was a problem hiding this comment.
Good point. I'll create a separate PR for this later. Thanks!
This was referenced Jul 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported fields:
og:titleog:type(with customloglist:quotetype)og:imageog:descriptionog:urlClose #170