Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu state context for convenience #1012

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Add menu state context for convenience #1012

merged 1 commit into from
Feb 20, 2025

Conversation

andrewkfiedler
Copy link
Contributor

  • In some scenarios it's useful to have context available for menustate to avoid the need for passing it down through multiple components in props. This mostly helps nested menus, but can be useful in other areas as well.

@andrewkfiedler
Copy link
Contributor Author

build now

@cxddfuibot
Copy link
Collaborator

Internal build has been started, your results will be available at build completion.

@cxddfuibot
Copy link
Collaborator

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

@cxddfuibot
Copy link
Collaborator

Suspected Failure(s):

  • Failed UI Tests

 - In some scenarios it's useful to have context available for menustate to avoid the need for passing it down through multiple components in props.  This mostly helps nested menus, but can be useful in other areas as well.
@andrewkfiedler
Copy link
Contributor Author

build now

@cxddfuibot
Copy link
Collaborator

Internal build has been started, your results will be available at build completion.

Copy link

An updated dist branch has been created and pushed to origin.
You can use:
"catalog-ui-search": "https://github.com/codice/ddf-ui#catalog-ui-search-dist-1012",
in your package.json to use this version in your project.

Remember to use "yarn install --force" if you want to pick up changes each time you make a change to this branch by committing.

github-actions bot pushed a commit that referenced this pull request Feb 20, 2025
@cxddfuibot
Copy link
Collaborator

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@jlcsmith jlcsmith merged commit 55df44a into master Feb 20, 2025
3 checks passed
Copy link

You can no longer use:
"catalog-ui-search": "https://github.com/codice/ddf-ui#catalog-ui-search-dist-1012",
in your package.json to use this version in your project, as it has been deleted now that the pull request is closed.

Instead, if the pr was merged you can now access these changes by using:
"catalog-ui-search": "https://github.com/codice/ddf-ui#catalog-ui-search-dist-snapshot",

Remember to use "yarn install --force" if you want to pick up changes to this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants