Fix SanitizerConfig type definition #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hata6502
requested review from
gohabereg,
khaydarov and
neSpecc
as code owners
hata6502
force-pushed
the
bugfix/fix-sanitizer-config-type
branch
3 times, most recently
from
b532025 to
75d12ea
Compare
hata6502
commented
Dec 8, 2020
src/types-internal/html-janitor.d.ts
Outdated
| interface Config { | ||
| tags: { | ||
| [key: string]: boolean|{[attr: string]: boolean|string}|(() => any) | ||
| [key: string]: Option | ((el: HTMLElement) => Option) |
There was a problem hiding this comment.
By adding el: HTMLElement, escape Type error with callback.
neSpecc
requested changes
Jan 26, 2021
src/types-internal/html-janitor.d.ts
Outdated
| @@ -3,9 +3,11 @@ | |||
| * After that we can use it at the TS modules | |||
| */ | |||
| declare module 'html-janitor' { | |||
| type Option = boolean | { [attr: string]: boolean | string }; | |||
types/configs/sanitizer-config.d.ts
Outdated
| @@ -1,3 +1,5 @@ | |||
| type Option = boolean | { [attr: string]: boolean | string }; | |||
hata6502
force-pushed
the
bugfix/fix-sanitizer-config-type
branch
from
929573b to
6d0943f
Compare
|
@neSpecc |
khaydarov
approved these changes
Feb 4, 2021
|
Please pull the |
|
@neSpecc I did |
Co-authored-by: Peter Savchenko <[email protected]>
hata6502
force-pushed
the
bugfix/fix-sanitizer-config-type
branch
from
8f97a6f to
6206f16
Compare
hata6502
force-pushed
the
bugfix/fix-sanitizer-config-type
branch
from
6206f16 to
e1f63e8
Compare
hata6502
commented
Feb 19, 2021
| @@ -560,7 +560,7 @@ export default class BlockManager extends Module { | |||
| * 2) Mark it as current | |||
| * | |||
| * @param {Node} childNode - look ahead from this node. | |||
| * @returns can return undefined in case when the passed child note is not a part of the current editor instance | |||
| * @returns {Block | undefined} can return undefined in case when the passed child note is not a part of the current editor instance | |||
There was a problem hiding this comment.
Fixed for yarn lint:fix
|
Resolved conflicts. |
gohabereg
approved these changes
Feb 27, 2021
neSpecc
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1513