Docs on caching specific wagtail pages and add missing quotes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! I didn't realize you could actually use the method decorator on the class - good addition to the docs. |
|
Thanks for this package. Everything works smoothly. Btw we are adding the package here HyphaApp/hypha#1160 |
|
Cool, glad it is useful to you. Feel free to make any pull requests or file an issue if you encounter any bugs or need functionality changes. |
vsalvino
reviewed
Apr 16, 2019
docs/getting_started/install.rst
Outdated
| @@ -186,6 +186,18 @@ To this:: | |||
| # Wrap the serve function with wagtail-cache | |||
| url(serve_pattern, cache_page(wagtail_views.serve), name='wagtail_serve'), | |||
|
|
|||
| Caching specific wagtail pages only | |||
There was a problem hiding this comment.
Should this heading say: "Caching specific wagtail page models only" since it appears this code would cache all pages using a specific model, not specific page instances. Correct?
There was a problem hiding this comment.
Thanks for catching it. Updated PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.