Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webhook test for VM webhook update #1070

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

rajivnathan
Copy link
Contributor

@rajivnathan rajivnathan commented Nov 22, 2024

Copy link

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,rajivnathan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add test cases for creating and updating vms with runStrategy set and expect that the webhook rejects that ?

Basically updating this test

func TestCreateVirtualMachine(t *testing.T) {
.

@rajivnathan
Copy link
Contributor Author

Should we add test cases for creating and updating vms with runStrategy set and expect that the webhook rejects that ?

Basically updating this test

func TestCreateVirtualMachine(t *testing.T) {

.

We mainly rely on unit testing for all the validating webhooks if I'm not mistaken. But if we think it's needed, I can give it a try.

@rajivnathan rajivnathan merged commit 023119b into codeready-toolchain:master Nov 26, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants