-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webhook test for VM webhook update #1070
Update webhook test for VM webhook update #1070
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, rajivnathan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add test cases for creating and updating vms with runStrategy
set and expect that the webhook rejects that ?
Basically updating this test
func TestCreateVirtualMachine(t *testing.T) { |
We mainly rely on unit testing for all the validating webhooks if I'm not mistaken. But if we think it's needed, I can give it a try. |
…e into vmWebhookUpdate
|
Paired with codeready-toolchain/member-operator#607