drop usage of userID for names of UserSignup

[MatousJobanek]

The final PR of the whole effort of dropping support for using userIds as the names of UserSignups KUBESAW-254

To simplify the code, the PR also removes the GetUserSignupFromIdentifier method as not needed anymore. Every caller that needs to get UserSignup resource can simply call Get with the encoded username.

paired PR: codeready-toolchain/toolchain-e2e#1105

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
10.3% Duplication on New Code

See analysis details on SonarQube Cloud

[alexeykazakov]

Nice!

[MatousJobanek]

/retest
created paired PR with the fixed test

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.11%. Comparing base (c7f9087) to head (1c7a6d3).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/verification/service/verification_service.go	50.00%	8 Missing and 5 partials ⚠️
pkg/proxy/proxy.go	94.44%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
- Coverage   85.12%   85.11%   -0.01%     
==========================================
  Files          32       32              
  Lines        3146     3118      -28     
==========================================
- Hits         2678     2654      -24     
+ Misses        380      376       -4     
  Partials       88       88              

Flag	Coverage Δ
unittests	85.11% <83.33%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment