Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUBESAW-250: Updating GolangCiLint to v1.63.1 #491

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Jan 8, 2025

@fbm3307
Copy link
Contributor Author

fbm3307 commented Jan 8, 2025

/test e2e
looks like some infra issue

@fbm3307
Copy link
Contributor Author

fbm3307 commented Jan 9, 2025

/test e2e
infra issue

@MatousJobanek
Copy link
Contributor

MatousJobanek commented Jan 13, 2025

/retest
infra

@fbm3307
Copy link
Contributor Author

fbm3307 commented Jan 15, 2025

/test e2e

@fbm3307
Copy link
Contributor Author

fbm3307 commented Jan 16, 2025

/test e2e
branch conflict

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (d2bb245) to head (b4080de).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #491   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files          32       32           
  Lines        3174     3174           
=======================================
  Hits         2710     2710           
  Misses        376      376           
  Partials       88       88           
Flag Coverage Δ
unittests 85.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek, metlos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,fbm3307,metlos]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fbm3307 fbm3307 merged commit 673149c into codeready-toolchain:master Jan 20, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants