Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop InformerService #479

Merged

Conversation

MatousJobanek
Copy link
Contributor

KUBESAW-198

Drops completely the InformerService interface and its implementation. All usages are replaced by calling the client directly.

Copy link

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.99%. Comparing base (66e3ec6) to head (a11d954).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/proxy/handlers/spacelister.go 0.00% 4 Missing ⚠️
pkg/server/in_cluster_application.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
+ Coverage   85.43%   85.99%   +0.56%     
==========================================
  Files          33       32       -1     
  Lines        2519     2499      -20     
==========================================
- Hits         2152     2149       -3     
+ Misses        281      265      -16     
+ Partials       86       85       -1     
Flag Coverage Δ
unittests 85.99% <87.75%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MatousJobanek MatousJobanek merged commit c2644e1 into codeready-toolchain:master Oct 11, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants