Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that startTime is not nil #636

Conversation

MatousJobanek
Copy link
Contributor

🤦‍♂️

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x194e580]

goroutine 593 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
	/tmp/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:116 +0x1e5
panic({0x1d9d220?, 0x34e8b00?})
	/opt/hostedtoolcache/go/1.21.13/x64/src/runtime/panic.go:914 +0x21f
github.com/codeready-toolchain/member-operator/controllers/idler.(*Reconciler).ensureIdling(0xc00063aba0, {0x23e6d60, 0xc010c2af90}, 0xc010c00c80)
	/home/runner/work/member-operator/member-operator/controllers/idler/idler_controller.go:184 +0x740
github.com/codeready-toolchain/member-operator/controllers/idler.(*Reconciler).Reconcile(0xc00063aba0, {0x23e6d60, 0xc010c2af90}, {{{0x0?, 0x5?}, {0xc00d7c57f0?, 0xc0083b3d08?}}})
	/home/runner/work/member-operator/member-operator/controllers/idler/idler_controller.go:114 +0x43e
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0x23eac00?, {0x23e6d60?, 0xc010c2af90?}, {{{0x0?, 0xb?}, {0xc00d7c57f0?, 0x0?}}})
	/tmp/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:119 +0xb7
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc000525220, {0x23e6d98, 0xc0001d9950}, {0x1e88760?, 0xc00be34f60?})
	/tmp/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:316 +0x3cc
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc000525220, {0x23e6d98, 0xc0001d9950})
	/tmp/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266 +0x1af
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
	/tmp/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227 +0x79
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2 in goroutine 114
	/tmp/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:223 +0x565

Copy link

sonarqubecloud bot commented Mar 7, 2025

Copy link

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MatousJobanek MatousJobanek merged commit 9ae2815 into codeready-toolchain:master Mar 7, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants