do not duplicate cached clients #635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatousJobanek
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
mfrancisc,
rsoaresd,
fbm3307,
metlos and
jrosental
as code owners
metlos
approved these changes
Mar 6, 2025
rajivnathan
reviewed
Mar 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #635 +/- ##
=======================================
Coverage 81.80% 81.80%
=======================================
Files 31 31
Lines 3352 3352
=======================================
Hits 2742 2742
Misses 460 460
Partials 150 150 🚀 New features to boost your workflow:
|
alexeykazakov
approved these changes
Mar 6, 2025
|
fbm3307
approved these changes
Mar 7, 2025
rajivnathan
approved these changes
Mar 7, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, metlos, mfrancisc, rajivnathan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rajivnathan noticed that we have duplicated cached all-namespaces scoped clients. This PR removes one of them to decrease the memory utilization.