-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use SSA to apply the template objects #634
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metlos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fcaa95d
to
aee1f7f
Compare
aee1f7f
to
dc4e7ed
Compare
|
/test e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #634 +/- ##
==========================================
+ Coverage 81.71% 81.73% +0.02%
==========================================
Files 29 29
Lines 3330 3334 +4
==========================================
+ Hits 2721 2725 +4
Misses 459 459
Partials 150 150
🚀 New features to boost your workflow:
|
Thanks a lot for the PR 👍
I would simply create a new function "next" to the existing one (in a separate file/package) and gradually propagate the change to all places in our code. In other words, can you please move the "apply" logic to toolchain-common? |
This is a minimal change in the member operator to start using the SSA to persist the changes to the templates.
I didn't do this change in
toolchain-common
to limit the "impact" this change would have at runtime across the ecosystem (i.e. not impact host-operator or ksctl).The future steps for this would be to drastically simplify the template apply logic in
toolchain-common
.As such, this is still more of an experiment than a definitive solution. At best, it is the first step in the larger effort to simplify the deployment of NSTemplateSets.