Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SANDBOX-808: update kube & openshift dependencies to 4.17 #629

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

rsoaresd
Copy link
Contributor

@rsoaresd rsoaresd commented Feb 19, 2025

Description

Update dependencies

Tool/Library Current Version Updates to Version
Golang 1.21 1.22
Operator SDK 1.36 1.38
k8s.io/* v0.29.2 v0.30.1
controller-runtime v0.17.3 v0.18.4

Note

Operator SDK will be updated in the next set of PRs along with toolchain-cicd and operators update

Issue ticket number and link

SANDBOX-808

Note

snyk reports a lot of vulnerabilities regarding go 1.22. From snyk's source, it seems all FPs. For more info, check this Slack thread

@rsoaresd rsoaresd force-pushed the openshift_4_17_member-operator branch from 7532013 to 7eb3e02 Compare February 19, 2025 12:21
@rsoaresd rsoaresd marked this pull request as draft February 19, 2025 14:20
@rsoaresd rsoaresd marked this pull request as ready for review February 19, 2025 15:08
@rsoaresd
Copy link
Contributor Author

/retest

very likely flaky test. i will keep an eye

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (fc36345) to head (c356b8f).

Files with missing lines Patch % Lines
...trollers/nstemplateset/nstemplateset_controller.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   81.71%   75.79%   -5.92%     
==========================================
  Files          29       44      +15     
  Lines        3330     4449    +1119     
==========================================
+ Hits         2721     3372     +651     
- Misses        459      927     +468     
  Partials      150      150              
Files with missing lines Coverage Δ
...trollers/nstemplateset/nstemplateset_controller.go 70.58% <0.00%> (ø)

... and 15 files with indirect coverage changes

sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
sigs.k8s.io/kustomize/api v0.13.5-0.20230601165947-6ce0bf390ce3 // indirect
sigs.k8s.io/kustomize/kyaml v0.14.3-0.20230601165947-6ce0bf390ce3 // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
)

go 1.21
go 1.22.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to test with the changes in api and common. Please add in a replace block and point to your fork here as in toolchain-common

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to push the commit, sorry!

Copy link
Contributor

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a replace block

@rsoaresd rsoaresd requested a review from ranakan19 February 19, 2025 22:31
Copy link

openshift-ci bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, ranakan19, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,fbm3307,ranakan19,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarqubecloud bot commented Mar 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants