Split ci-build.yml #557
Merged
Split ci-build.yml #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feny Mehta <[email protected]>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
|
mfrancisc
approved these changes
Apr 5, 2024
mfrancisc
approved these changes
Apr 5, 2024
xcoulon
approved these changes
Apr 5, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, mfrancisc, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #557 +/- ##
=======================================
Coverage 84.05% 84.05%
=======================================
Files 29 29
Lines 2634 2634
=======================================
Hits 2214 2214
Misses 277 277
Partials 143 143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split the ci-build.yml file into following two files
test-with-coverage.yml
ci-golang-sbom.yml
By updating pull_request_target to have tokens the workflow automatically checks out the code from master and not from PR.
This fix is needed only for the tests to upload codecov report, not for linters and hence spliting the workflow