Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node to 10.15.1 #472

Merged
merged 11 commits into from
Apr 16, 2019
Merged

Update node to 10.15.1 #472

merged 11 commits into from
Apr 16, 2019

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Apr 9, 2019 •
edited
Loading

@code-asher code-asher changed the title Update node Update node to 10.15.1 Apr 9, 2019
@code-asher code-asher force-pushed the feature/update-node branch from cde3271 to 9de6400 Compare April 9, 2019 19:34
@code-asher code-asher marked this pull request as ready for review April 9, 2019 19:44
nhooyr
nhooyr suggested changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as the docker file builds

@nhooyr
Copy link
Contributor

nhooyr commented Apr 9, 2019

whoops meant to approve

nhooyr
nhooyr reviewed Apr 9, 2019
View reviewed changes
@code-asher code-asher force-pushed the feature/update-node branch from 7867b5e to c07a150 Compare April 9, 2019 20:27
@code-asher code-asher force-pushed the feature/update-node branch from c07a150 to 827dae6 Compare April 9, 2019 20:28
@code-asher code-asher added the wip label Apr 9, 2019
@code-asher
Copy link
Member Author

Adding wip tag because it's not running correctly when I build it with Docker.

@code-asher
Copy link
Member Author

code-asher commented Apr 9, 2019 •
edited
Loading

Wasn't related to Docker, the spdlog dependencies needed to be included since it's external now. But there is another issue where bindings tries to look for the package.json and fails. It fails finding anything in /node_modules/spdlog, but those files appear to be included when bundling. 😕 Everything works now including Docker...except it seems to exit without any errors once the page loads. Edit: ah, it's a segfault. The shared process also continually exits with no errors and no exit code (probably segfaulting). <-- fixed by coder/nbin#5

@code-asher
Add node_modules to Docker ignore
8162e0f 
It keeps using my already-built .node files which results in a
mismatching GLIBC version error.
@code-asher code-asher added the blocked This issue cannot proceed due to external factors label Apr 11, 2019
@code-asher
Copy link
Member Author

Blocked on coder/nbin#5.

@visualphoenix
Copy link

visualphoenix commented Apr 15, 2019 •
edited
Loading

+1 updating past node.js 10.10 will get you nodejs/node#22609 which might help when running code-server in mesos with a randomly assigned uid/gid that doesnt exist

@code-asher code-asher removed the blocked This issue cannot proceed due to external factors label Apr 15, 2019
@code-asher code-asher removed the wip label Apr 15, 2019
@visualphoenix
Copy link

visualphoenix commented Apr 15, 2019 via email

@foresthoffman
Copy link
Contributor

@visualphoenix What platform are you on? What errors are you receiving?

@visualphoenix
Copy link

visualphoenix commented Apr 15, 2019 via email

@visualphoenix
Copy link

visualphoenix commented Apr 15, 2019 via email

@code-asher code-asher merged commit aabb2ec into master Apr 16, 2019
@code-asher code-asher deleted the feature/update-node branch April 16, 2019 00:48
@code-asher
Copy link
Member Author

@visualphoenix if you could open an issue with the error you're getting, that would be fantastic. Thank you!

@code-asher code-asher mentioned this pull request Apr 17, 2019
Closed
code-asher added a commit that referenced this pull request Jun 19, 2019
@code-asher
Update node to 10.15.1 (#472)
70cd939 
* Update Node to 10.15.1

* Remove string replace that was used for oclif

* Update nbin

* Package node-pty and spdlog with nbin

* Label stderr/stdout from shared process

* Remove fork override

* Prevent "already disposed" errors when trying to kill disposed proxies

* Include spdlog dependencies

* Shim /node_modules

* Add node_modules to Docker ignore

It keeps using my already-built .node files which results in a
mismatching GLIBC version error.

* Update nbin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr nhooyr requested changes

@MichaelDesantis MichaelDesantis MichaelDesantis left review comments

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directory being made upon opening file (.ts) Use nbin for native modules Markdown preview not working
6 participants
@code-asher @nhooyr @visualphoenix @foresthoffman @kylecarbs @MichaelDesantis