-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(install): add uninstall instructions #3840
Conversation
docs/install.md
Outdated
|
||
### install.sh | ||
|
||
If you installed with the install script, by default code-server will be in `~/usr/lib/code-server` and you can remove it with `rm -rf`. e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Is ~/usr/lib/code-server
the right path? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to install.sh
The release is unarchived into ~/.local/lib/code-server-X.X.X
and the binary symlinked into ~/.local/bin/code-server
So no that is not right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated for the unarchived. Wondering if we also need to tell them to remove the binary in /bin
Codecov Report
@@ Coverage Diff @@
## main #3840 +/- ##
=======================================
Coverage 62.60% 62.60%
=======================================
Files 36 36
Lines 1872 1872
Branches 379 379
=======================================
Hits 1172 1172
Misses 595 595
Partials 105 105 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits but otherwise this is a great addition. It would be especially nice if we could follow up with a programmatic means to identify the installation path e.g.
code-server --installation-prefix
code-server --config-prefix
I think I understand what you mean, but to be extra clear, you're suggesting adding these as flags/args to run with |
f17bab5
to
5e45a93
Compare
5e45a93
to
162f70a
Compare
This PR adds an "Uninstall" section to the
install.md
docs. I decied to add this because I noticed a trend in GitHub Discusions where people have asked how to do this:Caveat
This does not cover all scenarios but it does cover the ones that have been asked about. I figured we can add more as it gets asked (issue/discussion drive development?).
Todos