Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update guides.md header to Accessing Web Services #3819

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Conversation

khorne3
Copy link
Contributor

@khorne3 khorne3 commented Jul 20, 2021

Fixes header on guides.md so that it reads "Accessing Web Services" instead of "Self signed certificates." Also updates in-text mention from "web service" to "web services."

@khorne3 khorne3 requested a review from a team as a code owner July 20, 2021 14:11
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #3819 (9d6a154) into main (475ae45) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3819   +/-   ##
=======================================
  Coverage   62.05%   62.05%           
=======================================
  Files          36       36           
  Lines        1863     1863           
  Branches      378      378           
=======================================
  Hits         1156     1156           
  Misses        601      601           
  Partials      106      106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475ae45...9d6a154. Read the comment docs.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for fixing this @khorne3 🎉

@jsjoeio jsjoeio added the docs Documentation related label Jul 20, 2021
@jsjoeio jsjoeio added this to the 3.12.0 milestone Jul 20, 2021
@khorne3 khorne3 merged commit a84dd25 into main Jul 20, 2021
@khorne3 khorne3 deleted the headers-fix branch July 20, 2021 18:14
@khorne3
Copy link
Contributor Author

khorne3 commented Jul 20, 2021

oops @jsjoeio not sure if that merged to the right place; please let me know if I need to revert so we can fix

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 20, 2021

@khorne3 i'll let you decide. before it was in FAQ, now you have it in Guide. Totally up to you!

@khorne3
Copy link
Contributor Author

khorne3 commented Jul 20, 2021

@jsjoeio ah sorry for the confusion; I just saw that you added it to 3.12.0 milestone and wasn't sure if this is ok to go into main?

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 20, 2021

Oh! It's okay to go into main. 3.11 was already released so that's why I added it to 3.12. We use the milestones to associate issues/PRs that were done in that cycle. Sorry for the confusion!

@jsjoeio jsjoeio modified the milestones: 3.12.0, 3.11.1 Aug 6, 2021
@ahmadyahya11 ahmadyahya11 mentioned this pull request Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants