Rename oneMKL to oneMath and improve the lesson/exercise #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the directory name, file names, and all references to oneMKL to the new name oneMath. Replace the global queue::wait calls with proper synchronisation, which is automatic in case of buffers and explicitly passing sycl::events into APIs with USM.
* Rename oneMKL to oneMath in the slides. * Rename the relevant files and directory accordingly * Improve the formatting of the slides * Expand the slides to explain what oneMath is
DuncanMcBain
approved these changes
Jan 14, 2025
…isation Same thing (in this case!) but fewer characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the upstream renaming, rename oneMKL to oneMath in both the lesson slides and the corresponding code exercise.
Also improve the material:
queue::waitcalls with proper synchronisation, which is automatic in case of buffers and explicitly passingsycl::eventsinto APIs with USM.Note that git marks the README, CMakeLists.txt and index.html as deleted files + new files added because the renaming affected many lines and the file name, but it's really just a file rename + a few edits. Unfortunately, this means git diff cannot be generated for them, so they can only be compared with a local diff (or by eye, side by side).