feat(packages/codemod-utils): add tsup and CJS for require support in codemod-utils #1474
+211
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
commit: |
amirabbas-gh
force-pushed
the
fix_codemod-utils_problem
branch
from
6d1135e to
9334c81
Compare
mohebifar
reviewed
Feb 4, 2025
| format: ["esm", "cjs"], | ||
| dts: { | ||
| compilerOptions: { | ||
| incremental: false, // Fix for incremental error |
There was a problem hiding this comment.
@mohebifar From my searches, I understand that we need a tsup.config for this package, and "incremental" on line 8 is for handling some errors.
codemod-com-bot
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
This PR adds
tsupas a build tool and includes CommonJS (.cjs) support in codemod-utils.With this change, the package can now be used with both
importandrequire, improving compatibility.🧪 Test Plan
tsupand verified that both ESM (.js) and CommonJS (.cjs) outputs were generated correctly.importandrequireenvironments to ensure compatibility.