Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql-hint addon] Add tests and fix #5817 #5819

Merged
merged 2 commits into from
Mar 20, 2019
Merged

[sql-hint addon] Add tests and fix #5817 #5819

merged 2 commits into from
Mar 20, 2019

Conversation

williamdes
Copy link
Contributor

@williamdes
Copy link
Contributor Author

You can see in https://travis-ci.org/codemirror/CodeMirror/builds/508598677#L491 that the object is wraped in an object, this is the issue #5819

{
    "text": {
        "text": "alias",
        "displayText": "alias | varchar(255) | Primary",
        "columnName": "alias",
        "columnHint": "varchar(255) | Primary"
    },
    "className": "CodeMirror-hint-table CodeMirror-hint-default-table"
}

MUST be

{
  "text": "alias",
  "displayText": "alias | varchar(255) | Primary",
  "columnName": "alias",
  "columnHint": "varchar(255) | Primary",
  "className": "CodeMirror-hint-table CodeMirror-hint-default-table"
}

@marijnh marijnh merged commit da99fdf into codemirror:master Mar 20, 2019
@marijnh
Copy link
Member

marijnh commented Mar 20, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants