-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove unneeded Entities\Cast\IntBoolCast #1186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not entirely sure, but as far as I remember, these features were added to the framework after they were identified as necessary in Shield. Since Shield also supports older versions of the framework, we need to ensure that these changes do not break compatibility.
Could you please investigate which version of the framework these features were introduced in and make sure that the proposed changes will not cause issues with older versions?
Thank you for sending this PR. |
We have phpunit test "phpunit / PHP 7.4 - MySQLi - lowest" that installs the lowest dependencies.
Ah, that is because v4.4.6 or below has one or more known vulnerabilities. |
@grimpirate See the version tags. |
@grimpirate Why did you close this? |
@kenjis sorry about that I thought based on the commit history that it was for backwards compatibility. I didn't think to compare the version numbers. |
@grimpirate Okay, no problem. As you see, your refactoring is okay. |
Description
While looking at the shield source code it was noted that the IntBoolCast class is already provided by codeigniter. Furthermore, the int_bool cast handler of the custom shield Entity already provided as an int-bool in the framework's default Entity. This commit cleans up redundant code.
Checklist: